Re: [cocci] [PATCH v4 1/5] coccinelle: misc: Add field_modify script

[Markus Elfring]

…
> ---
>  scripts/coccinelle/misc/field_modify.cocci | 61 ++++++++++++++++++++++++++++++
…

Did you overlook the addition of patch version descriptions?
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15#n310


…
> +@ depends on context && !patch && !org && !report@
…

I imagine that the condition selections can be simplified.


…
> +@script:python depends on report@
> +p << r.p;
> +x << r.reg;
> +@@
> +
> +msg="WARNING: Consider using FIELD_MODIFY helper on %s" % (x)
> +coccilib.report.print_report(p[0], msg)
Do you know that a string construction can also be directly passed
to such a function call?

Regards,
Markus