Re: [GIT PULL] Kbuild updates for v6.16-rc1
From: Masahiro Yamada
Date: Thu Jun 12 2025 - 12:15:40 EST
On Thu, Jun 12, 2025 at 11:29 PM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
>
> On Thu, Jun 12, 2025 at 10:01:00AM +0200, Arnd Bergmann wrote:
> > On Thu, Jun 12, 2025, at 03:42, Masahiro Yamada wrote:
> > > On Wed, Jun 11, 2025 at 11:24 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > >> On Wed, Jun 11, 2025, at 15:32, Masahiro Yamada wrote:
> > >> > On Wed, Jun 11, 2025 at 4:55 PM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> > >> I think this makes sense in general, but the output here is
> > >> excessive if it leads to users no longer wanting to enable W=1.
> > >>
> > >> There are other warnings that I think should be enabled at the
> > >> W=1 level (e.g. -Wformat-security) and eventually by default,
> > >> but that are still too noisy at that level.
> > >>
> > >> My own cutoff would be at a few hundred warnings in allmodconfig
> > >> builds if there is an effort to reduce it further, but it seems
> > >> that this one is still at a few thousand, which does not seem ok.
> > >
> > > Then, what to do? Downgrade to W=2?
> > >
> > > I think nobody cares about W=2 builds,
> >
> > I think the first step would be mass-cleanup patches to get
> > the initial numbers down. A lot of this can be scripted.
>
> I'm not sure this should be separate patches which would then be sent for
> review. This is way too much churn for something trivial like this. Only very
> few patches have been posted yet, and discussions started:
>
> https://lore.kernel.org/all/aEjwqtotEEH8QMHB@xxxxxxxxxxxxxxxxxxx
> https://lore.kernel.org/all/aEl9kO81-kp0hhw0@xxxxxxxxxx
> https://lore.kernel.org/all/CAHp75Vc7AO_sRgB1Nj6CevbseMFyv5ku8ZS3PwzAuAgysKVxNg@xxxxxxxxxxxxxx
>
> This looks like the start of an immense waste of developer time.
>
> Can't this be scripted and be addressed with a single commit shortly
> after/before the next merge window closes?
https://lore.kernel.org/linux-kbuild/20250612160850.3007038-1-masahiroy@xxxxxxxxxx/T/#u
--
Best Regards
Masahiro Yamada