Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

[David Hildenbrand]

On 12.06.25 17:28, Lorenzo Stoakes wrote:
> On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote:
> > We setup the cache mode but ... don't forward the updated pgprot to
> > insert_pfn_pud().
> >
> > Only a problem on x86-64 PAT when mapping PFNs using PUDs that
> > require a special cachemode.
> >
> > Fix it by using the proper pgprot where the cachemode was setup.
> >
> > Identified by code inspection.
> >
> > Fixes: 7b806d229ef1 ("mm: remove vmf_insert_pfn_xxx_prot() for huge page-table entries")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
>
> Nice catch!
>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>

Thanks! What's your opinion on stable? Really hard to judge the impact ...

--
Cheers,

David / dhildenb