Re: [PATCH net 7/9] net/mlx5e: Properly access RCU protected qdisc_sleeping variable

[Mark Bloch]

On 12/06/2025 17:22, Jakub Kicinski wrote:
> On Thu, 12 Jun 2025 10:31:45 +0300 Mark Bloch wrote:
>>> I don't think this is a functional change? We don't treat silencing
>>> compiler warnings as fixes, not for sparse or W=1 warnings.  
>>
>> Well Eric's commit: d636fc5dd692c8f4e00ae6e0359c0eceeb5d9bdb
>> that added this annotation was because of a syzbot report.
> 
> And your point is?

I just mean there's a reason for using annotations, and being
the odd one out feels off. I also wouldn't want anyone to
accidentally reference that logic (if they add HTB offloads support).

Will push via net-next.

Mark