Re: [PATCH] hns3: work around stack size warning

[Jakub Kicinski]

On Thu, 12 Jun 2025 21:09:40 +0800 Jijie Shao wrote:
> >> Would you please help test whether the following changes have solved
> >> your problem,
> >> And I'm not sure if this patch should be sent to net or net-next...  
> > Your patch arrived with whitespace corruption here, so I could not
> > try it, but I'm sure it would help avoid the warning.
> >
> > However, this is not what meant with my suggestion: you already
> > allocate a temporary buffer in hns3_dbg_open() and I would
> > expect it to be possible to read into that buffer directly
> > without a second temporary buffer (on stack or kmalloc).
> >
> > The normal way of doing this would be to use the infrastructure
> > from seq_file and then seq_printf() and not have any extra buffers
> > on top of that.
> 
> seq_file is good. But the change is quite big.
> I need to discuss it internally, and it may not be completed so quickly.
> I will also need consider the maintainer's suggestion.

Arnd, do you mind waiting? We can apply your patch as is if the warning
is a nuisance.