Re: [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled

From: Lorenzo Stoakes
Date: Thu Jun 12 2025 - 09:40:42 EST


On Thu, Jun 12, 2025 at 03:13:19PM +0200, David Hildenbrand wrote:
[snip]
>
> The masks are just disgusting :(

Yeah I was shocked when I saw this implementation it's bloody terrible. It just
is.

>
> While you were writing that reply, I just sent out something else. Not sure
> if that makes sense.

Replied there :>)

>
> I'm having a hard time figuring out what we even want here in the existing
> code.

I'm confused as to why this has been done in this way in general.

I feel a churny refactoring coming on... ;)

>
> --
> Cheers,
>
> David / dhildenb
>