Re: [PATCH net] ionic: Prevent driver/fw getting out of sync on devcmd(s)

From: Simon Horman
Date: Thu Jun 12 2025 - 09:11:13 EST


On Mon, Jun 09, 2025 at 02:28:27PM -0700, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@xxxxxxx>
>
> Some stress/negative firmware testing around devcmd(s) returning
> EAGAIN found that the done bit could get out of sync in the
> firmware when it wasn't cleared in a retry case.
>
> While here, change the type of the local done variable to a bool
> to match the return type from ionic_dev_cmd_done().
>
> Fixes: ec8ee714736e ("ionic: stretch heartbeat detection")
> Signed-off-by: Brett Creeley <brett.creeley@xxxxxxx>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>