Re: [PATCH v3 5/5] iio: amplifiers: ada4250: use dev_err_probe()

[Andy Shevchenko]

On Wed, Jun 11, 2025 at 04:33:05PM -0500, David Lechner wrote:
> Use dev_err_probe() when returning an error in the probe function.

...

>  	mutex_init(&st->lock);

Side note. Switch to devm?

...

>  	ret = ada4250_init(st);

Is this used only in ->probe() stage? If so, please also move to
dev_err_probe() there.

> -	if (ret) {
> -		dev_err(&spi->dev, "ADA4250 init failed\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n");
>  
>  	return devm_iio_device_register(&spi->dev, indio_dev);

-- 
With Best Regards,
Andy Shevchenko