Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support

[Geert Uytterhoeven]

Hi Prabhakar,

On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> supports host/function operation.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> @@ -302,6 +317,16 @@ sd1-dat-cmd {
>                         slew-rate = <0>;
>                 };
>         };
> +
> +       usb20_pins: usb20 {
> +               ovc {
> +                       pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */

Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
not on RZ/V2N EVK?

> +               };
> +
> +               vbus {
> +                       pinmux = <RZV2N_PORT_PINMUX(9, 5, 14)>; /* VBUS */
> +               };
> +       };
>  };
>
>  &qextal_clk {

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.17 when the above is sorted out.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds