Re: [PATCH net-next 2/8] net: hns3: add the hns3_get_ae_dev() helper

[Jijie Shao]

on 2025/6/12 19:16, Michal Swiatkowski wrote:
> On Thu, Jun 12, 2025 at 10:13:11AM +0800, Jijie Shao wrote:
> > This patch introduces a hns3_get_ae_dev() helper to reduce the unnecessary
> > middle layer conversion. Apply it to the whole HNS3 driver.
> > The former discusstion can be checked from the link.
> The definition already exist, so more like "use hns3_get_ae_dev()
> wherever possible".
>
> > Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230310081404.947-1-lanhao@xxxxxxxxxx/
> I think the comment is about going from netdev to your private
> hnae3_ae_dev. You need hnae3_netdev_to_dev/pf/whatever().
>
> Using already defined helper is fine, just please change the commit
> message/title.


I will change this in v2.

Thanks,
Jijie SHao

> > Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> [...]