Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry
From: Krzysztof Kozlowski
Date: Thu Jun 12 2025 - 07:30:10 EST
On 11/06/2025 14:24, Akhil P Oommen wrote:
>>>
>>> patternProperties:
>>> - '^opp-[0-9]+$':
>>> + '^opp(-?[0-9]+)*$':
>>
>> Not correct regex. You allow "opp", "opp1" and all other unusual
>> variants. Commit does not explain what problem you are solving, so I
>> have no clue what you want here, but for sure opp1 is wrong.
>
> Just to confirm, would this be fine for the requirement I mentioned above?
>
> "'^opp(-[0-9]+)*$'"
No, You did not solve half of the problems - still allows "opp" and
commit msg does not explain why "opp" is now correct. Describe the
actual problem and then write the regex solving it in specific way, not
causing other effects.
Best regards,
Krzysztof