Re: [PATCH v2] md/raid1: Fix stack memory use after return in raid1_reshape

[Yu Kuai]

Hi,

在 2025/06/12 17:55, Wang Jinchao 写道:
> Now that we have the same information, I prefer patch-v1 before 
> refactoring raid1_reshape,
> because it’s really simple (only one line) and clearer to show the 
> backup and restore logic.
> Another reason is that v2 freezes the RAID longer than v1.
> Would you like me to provide a v3 patch combining the v2 explanation 
> with the v1 diff?
> Thanks for your reviewing.

I don't have preference here, feel free to do this.

BTW, I feel raid1_reshape can be better coding with following：

- covert r1bio_pool to use mempool_create_kmalloc_pool(use create
instead of init to get rid of the werid assigment);
- no need to reallocate pool_info;
- convert raid1_info to use krealloc;

Welcome if you are willing to, otherwise I'll find myself sometime.

Thanks,
Kuai