Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC

[Gaurav Kohli]

On 6/11/2025 8:17 PM, Konrad Dybcio wrote:
> On 6/11/25 4:19 PM, Dmitry Baryshkov wrote:
> > On Wed, Jun 11, 2025 at 04:08:57PM +0200, Konrad Dybcio wrote:
> > > On 6/11/25 8:37 AM, Gaurav Kohli wrote:
> > > > Add TSENS and thermal devicetree node for QCS615 SoC.
> > > >
> > > > Signed-off-by: Gaurav Kohli <quic_gkohli@xxxxxxxxxxx>
> > > > ---
> > >
> > > [...]
> > >
> > > > +	thermal-zones {
> > > > +		aoss-thermal {
> > > > +			thermal-sensors = <&tsens0 0>;
> > > > +
> > > > +			trips {
> > > > +				trip-point0 {
> > > > +					temperature = <110000>;
> > > > +					hysteresis = <5000>;
> > > > +					type = "passive";
> > >
> > > All of the passive trip points you added that aren't bound to any
> > > cooling devices should be critical instead (otherwise they're not
> > > doing anything)
> > >
> > > otherwise, looks good
thanks for the review & comment, let me send 3rd patch with critical for 
all trips.
> > Don't we need cooling-maps for CPU thermal zones?
>
> no, we have lmh
>
> Konrad