Re: [PATCH] drm/bridge: adv7511: Convert comma to semicolon

[Laurent Pinchart]

Hi Chen,

Thank you for the patch.

On Thu, Jun 12, 2025 at 01:52:18PM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

This should have

Fixes: ae01d3183d27 ("drm/bridge: adv7511: switch to the HDMI connector helpers")

While at it, I would also remove the parentheses. With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 9df18a8f2e37..418a403586f6 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1278,7 +1278,7 @@ static int adv7511_probe(struct i2c_client *i2c)
>  						  SNDRV_PCM_FMTBIT_S20_3LE |
>  						  SNDRV_PCM_FMTBIT_S24_3LE |
>  						  SNDRV_PCM_FMTBIT_S24_LE |
> -						  SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE),
> +						  SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE);
>  	adv7511->bridge.hdmi_audio_spdif_playback = 1;
>  	adv7511->bridge.hdmi_audio_dai_port = 2;
>  #endif

-- 
Regards,

Laurent Pinchart