Re: [PATCH] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw_cleanup
From: Leon Romanovsky
Date: Thu Jun 12 2025 - 05:05:48 EST
On Tue, 10 Jun 2025 11:28:42 +0200, Arnd Bergmann wrote:
> This function has an array of eight mlx5_async_cmd structures, which
> often fits on the stack, but depending on the configuration can
> end up blowing the stack frame warning limit:
>
> drivers/infiniband/hw/mlx5/devx.c:2670:6: error: stack frame size (1392) exceeds limit (1280) in 'mlx5_ib_ufile_hw_cleanup' [-Werror,-Wframe-larger-than]
>
> Change this to a dynamic allocation instead. While a kmalloc()
> can theoretically fail, a GFP_KERNEL allocation under a page will
> block until memory has been freed up, so in the worst case, this
> only adds extra time in an already constrained environment.
>
> [...]
Applied, thanks!
[1/1] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw_cleanup
https://git.kernel.org/rdma/rdma/c/b26852daaa83f5
Best regards,
--
Leon Romanovsky <leon@xxxxxxxxxx>