Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

From: Cristian Ciocaltea
Date: Thu Jun 12 2025 - 03:49:12 EST


On 6/12/25 10:30 AM, Takashi Iwai wrote:
> On Thu, 12 Jun 2025 09:22:36 +0200,
> Cristian Ciocaltea wrote:
>>
>> On 6/12/25 9:52 AM, Takashi Iwai wrote:
>>> On Thu, 12 Jun 2025 08:02:28 +0200,
>>> Chen Ni wrote:
>>>>
>>>> Replace comma between expressions with semicolons.
>>>>
>>>> Using a ',' in place of a ';' can have unintended side effects.
>>>> Although that is not the case here, it is seems best to use ';'
>>>> unless ',' is intended.
>>>>
>>>> Found by inspection.
>>>> No functional change intended.
>>>> Compile tested only.
>>>>
>>>> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
>>>
>>> Thanks, applied now.
>>>
>>> At the next time, though, it'd be appreciated if you can put the
>>> proper Fixes tag.
>>
>> Considering this is not really a functional change, I think a
>> Fixes tag would trigger an unnecessary backport, wouldn't it?
>
> If it were in the old released kernels, I wouldn't be bothered,
> either. But this is still in staging for the next, and having Fixes
> tag will help to track if someone tries to backport patches.
> Otherwise the code differs and may give conflicts in further
> backports.

Oh, indeed, thanks for pointing this out!

Regards,
Cristian