Re: [PATCH v2] nfsd: Use correct error code when decoding extents

From: Christoph Hellwig
Date: Thu Jun 12 2025 - 03:00:31 EST


On Wed, Jun 11, 2025 at 11:55:02PM +0300, Sergey Bashirov wrote:
> if (nr_iomaps < 0)
> - return nfserrno(nr_iomaps);
> + return cpu_to_be32(-nr_iomaps);

This still feels like an odd calling convention. Maybe we should just
change the calling convention to return the __be32 encoded nfs errno
and have a separate output argument for the number of iomaps?

Chuck, any preference?