Re: [PATCH] net: pfcp: fix typo in message_priority field name
From: Ruben Kelevra
Date: Thu Jun 12 2025 - 02:38:50 EST
Hi Jakub,
I hit it while building an out-of-tree module that reads hdr->message_priority.
Cross-compiling for a big-endian target failed for me, because of it.
That’s the only reason for the patch; net-next is fine, no need for stable.
Cheers,
Ruben
On Wed, Jun 11, 2025 at 11:51 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
> > > Fix 'message_priprity' typo to 'message_priority' in big endian
> > > bitfield definition. This typo breaks compilation on big endian
> > > architectures.
> > >
> > > Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Cc: stable@xxxxxxxxxxxxxxx # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Signed-off-by: RubenKelevra <rubenkelevra@xxxxxxxxx>
> >
> > I had the same issue today, happy there's a patch for this.
>
> Could y'all share more? What compilation does this break?
> The field is never used.
>
> More info about how you found the problem would be useful.
> And I believe this can go to net-next, without the CC stable
> and without the Fixes tag. Unless my grep is lying to me:
>
> net-next$ git grep message_priority
> include/net/pfcp.h: u8 message_priority:4,
> --
> pw-bot: cr