Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon
From: Cristian Ciocaltea
Date: Thu Jun 12 2025 - 02:15:08 EST
On 6/12/25 9:02 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
> sound/usb/mixer_quirks.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 0769ecd91144..a0ffe8b559dc 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -762,9 +762,9 @@ static int snd_dualsense_jack_create(struct usb_mixer_interface *mixer,
>
> mei->ih.event = snd_dualsense_ih_event;
> mei->ih.match = snd_dualsense_ih_match;
> - mei->ih.connect = snd_dualsense_ih_connect,
> - mei->ih.disconnect = snd_dualsense_ih_disconnect,
> - mei->ih.start = snd_dualsense_ih_start,
> + mei->ih.connect = snd_dualsense_ih_connect;
> + mei->ih.disconnect = snd_dualsense_ih_disconnect;
> + mei->ih.start = snd_dualsense_ih_start;
> mei->ih.name = name;
> mei->ih.id_table = mei->id_table;
Thanks for catching this!
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>