Re: [PATCH 1/2] VFS: change old_dir and new_dir in struct renamedata to dentrys

From: Miklos Szeredi
Date: Thu Jun 12 2025 - 02:10:55 EST


On Thu, 12 Jun 2025 at 01:38, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> Umm... No objections, as long as overlayfs part is correct; it seems
> to be, but I hadn't checked every chunk there...

Overlayfs parts looks okay too.

A followup would be nice (e.g. make ovl_cleanup() take a dentry for
the directory as well, etc) so that there's no need to have local
variables for both the inode and dentry of the directory.

Thanks,
Miklos