Re: [PATCH v5 2/2] crypto: ti: Add driver for DTHE V2 AES Engine (ECB, CBC)

From: T Pratham
Date: Thu Jun 12 2025 - 01:49:43 EST


On 11/06/25 15:02, Herbert Xu wrote:
> On Tue, Jun 03, 2025 at 06:07:29PM +0530, T Pratham wrote:
>>
>> +static void dthe_cipher_exit_tfm(struct crypto_skcipher *tfm)
>> +{
>> + struct dthe_tfm_ctx *ctx = crypto_skcipher_ctx(tfm);
>> +
>> + ctx->keylen = 0;
>> +}
>
> This is pointless. Just get rid of the exit_tfm function.
>
> Cheers,

Okay. I was under the impression that init and exit functions were mandatory. Seems like they are not. I'll remove this function.

Regards
T Pratham <t-pratham@xxxxxx>