Re: [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
From: Andrew Jeffery
Date: Thu Jun 12 2025 - 01:32:18 EST
Hi Ankit, thanks for the fix.
Regarding the subject, can you please use the prefix 'ARM: dts:
aspeed:'? From there, I'd prefer something like:
ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes
On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote:
> Fix an obvious spelling error in the dts file for Lanyang BMC.
> This was reported by bugzilla a few years ago but never got fixed.
>
> Reported by: Jens Schleusener <Jens.Schleusener@xxxxxxxxxxx>
Please make sure these tags reflect convention:
https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Rather than spaces, they use `-` to separate words, so:
Reported-by: ...
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
>
> Signed-off-by: Ankit Chauhan <ankitchauhan2065@xxxxxxxxx>
Finally, all the tags should go together in the 'trailer' (final
paragraph). There should not be an empty line between the `Closes:` tag
and your `Signed-off-by:` tag above.
Cheers,
Andrew