Re: [PATCH v2 04/18] KVM: x86: Drop superfluous kvm_hv_set_sint() => kvm_hv_synic_set_irq() wrapper

[Huang, Kai]

On Wed, 2025-06-11 at 14:35 -0700, Sean Christopherson wrote:
> Drop the superfluous kvm_hv_set_sint() and instead wire up ->set() directly
> to its final destination, kvm_hv_synic_set_irq().  Keep hv_synic_set_irq()
> instead of kvm_hv_set_sint() to provide some amount of consistency in the
> ->set() helpers, e.g. to match kvm_pic_set_irq() and kvm_ioapic_set_irq().
> 
> kvm_set_msi() is arguably the oddball, e.g. kvm_set_msi_irq() should be
> something like kvm_msi_to_lapic_irq() so that kvm_set_msi() can instead be
> kvm_set_msi_irq(), but that's a future problem to solve.

Agreed on kvm_msi_to_lapic_irq(), but isn't kvm_msi_set_irq() a matter match
to kvm_{pic/ioapic/hv_synic}_set_irq()?  :-)

> 
> No functional change intended.
> 
> Cc: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> Cc: Kai Huang <kai.huang@xxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Acked-by: Kai Huang <kai.huang@xxxxxxxxx>