Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

[Andrew Davis]

On 6/9/25 10:43 AM, Kory Maincent wrote:
> Enable the TPS65219 regulator in the defconfig, as the TPS65214
> variant is used by the newly introduced BeagleBoard Green Eco board.
>
> Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
>   arch/arm/configs/omap2plus_defconfig | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 9f9780c8e62a..2ad669f7b202 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig

Why omap2plus_defconfig? OMAP3 and newer are all ARMv7 and
boards with those can/should use multi_v7_defconfig.

OMAP1 and OMAP2 are the only devices that cannot use multi_v7_defconfig
as they are not ARMv7. So I'd almost recommend we rename
omap2plus_defconfig to just omap2_defconfig to avoid more confusion.
Then we would have:

OMAP1:  ARMv4/5: omap1_defconfig
OMAP2:  ARMv6:   omap2_defconfig
OMAP3+: ARMv7:   multi_v7_defconfig

Any issue with that I'm missing?

Andrew

> @@ -385,6 +385,7 @@ CONFIG_TOUCHSCREEN_TSC2007=m
>   CONFIG_INPUT_MISC=y
>   CONFIG_INPUT_CPCAP_PWRBUTTON=m
>   CONFIG_INPUT_TPS65218_PWRBUTTON=m
> +CONFIG_INPUT_TPS65219_PWRBUTTON=m
>   CONFIG_INPUT_TWL4030_PWRBUTTON=m
>   CONFIG_INPUT_UINPUT=m
>   CONFIG_INPUT_PALMAS_PWRBUTTON=m
> @@ -454,6 +455,7 @@ CONFIG_MFD_TPS65217=y
>   CONFIG_MFD_TI_LP873X=y
>   CONFIG_MFD_TI_LP87565=y
>   CONFIG_MFD_TPS65218=y
> +CONFIG_MFD_TPS65219=y
>   CONFIG_MFD_TPS65910=y
>   CONFIG_TWL6040_CORE=y
>   CONFIG_REGULATOR_CPCAP=y
> @@ -470,6 +472,7 @@ CONFIG_REGULATOR_TPS65023=y
>   CONFIG_REGULATOR_TPS6507X=y
>   CONFIG_REGULATOR_TPS65217=y
>   CONFIG_REGULATOR_TPS65218=y
> +CONFIG_REGULATOR_TPS65219=y
>   CONFIG_REGULATOR_TPS65910=y
>   CONFIG_REGULATOR_TWL4030=y
>   CONFIG_RC_CORE=m