Re: [PATCH 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out

[Dan Carpenter]

On Wed, Jun 11, 2025 at 11:30:30AM -0700, Karan Tilak Kumar wrote:
> When both the RHBA and RPA FDMI requests time out, fnic reuses a frame
> to send ABTS for each of them. On send completion, this causes an
> attempt to free the same frame twice that leads to a crash.
> 
> Fix crash by allocating separate frames for RHBA and RPA,
> and modify ABTS logic accordingly.
> 
> Tested by checking MDS for FDMI information.
> Tested by using instrumented driver to:
> Drop PLOGI response
> Drop RHBA response
> Drop RPA response
> Drop RHBA and RPA response
> Drop PLOGI response + ABTS response
> Drop RHBA response + ABTS response
> Drop RPA response + ABTS response
> Drop RHBA and RPA response + ABTS response for both of them
> 
> Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
> Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
> Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx>
> Tested-by: Arun Easi <aeasi@xxxxxxxxx>
> Co-developed-by: Arun Easi <aeasi@xxxxxxxxx>
> Signed-off-by: Arun Easi <aeasi@xxxxxxxxx>
> Tested-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
> Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
> ---

This needs a Fixes tag and a CC to stable.

regards,
dan carpenter