Re: [PATCH v11 3/5] rust: add bitmap API.
From: Burak Emir
Date: Wed Jun 11 2025 - 13:24:54 EST
On Thu, Jun 5, 2025 at 11:20 PM Pekka Ristola <pekkarr@xxxxxxxxxxxxxx> wrote:
>
> On Monday, June 2nd, 2025 at 16.53, Burak Emir <bqe@xxxxxxxxxx> wrote:
[...]
>
> > + ($cond:expr, $($arg:tt)+) => {
> > + #[cfg(RUST_BITMAP_HARDENED)]
>
> The config name should be prefixed with `CONFIG_`.
>
> > + assert!($e, $($arg)*);
>
> `$e` is not defined, it should be `$cond`.
>
Thanks for pointing out the macro and config mistakes around
CONFIG_RUST_BITMAP_HARDENED.
Fixing all these.
I could not get kunit to enable RUST_BITMAP_HARDENED - now I understand why!
Also added the missing test now, exercised the code and observed the
fault (though [should_panic] does not seem to work).
Cheers,
- Burak