Re: [PATCH] drm/ssd130x: fix ssd132x_clear_screen() columns

[Thomas Zimmermann]

Hi

Am 11.06.25 um 14:47 schrieb Javier Martinez Canillas:
> John Keeping <jkeeping@xxxxxxxxxxxxxxxxx> writes:
>
> Hello John,
>
> > The number of columns relates to the width, not the height.  Use the
> > correct variable.
> >
> > Signed-off-by: John Keeping <jkeeping@xxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/solomon/ssd130x.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
> > index dd2006d51c7a2..eec43d1a55951 100644
> > --- a/drivers/gpu/drm/solomon/ssd130x.c
> > +++ b/drivers/gpu/drm/solomon/ssd130x.c
> > @@ -974,7 +974,7 @@ static void ssd130x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
> >   
> >   static void ssd132x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
> >   {
> > -	unsigned int columns = DIV_ROUND_UP(ssd130x->height, SSD132X_SEGMENT_WIDTH);
> > +	unsigned int columns = DIV_ROUND_UP(ssd130x->width, SSD132X_SEGMENT_WIDTH);
> >   	unsigned int height = ssd130x->height;
> >   
> Ups, indeed. Thanks for fixing it!
>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Could you please add a Fixes tag before merging the patch? Thanks!

Best regards
Thomas

>

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)