Re: [GIT PULL] Kbuild updates for v6.16-rc1

From: Arnd Bergmann
Date: Wed Jun 11 2025 - 10:26:15 EST


On Wed, Jun 11, 2025, at 15:32, Masahiro Yamada wrote:
> On Wed, Jun 11, 2025 at 4:55 PM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
>>
>> Don't get me wrong, I can address all of this trivial churn for s390, however
>> enforcing so many extra warnings to everyone with W=1 builds doesn't look like
>> the right approach to me.
>
> This is what W=1 is for.
> 0day bot detects a new W=1 warning, so we can avoid new warnings coming in.
>
> People do not know which headers should be included when.
> So, this warning must exist at least until we can get rid of
> #include <linux/export.h> from include/linux/module.h,
> include/linux/linkage.h etc.

I think this makes sense in general, but the output here is
excessive if it leads to users no longer wanting to enable W=1.

There are other warnings that I think should be enabled at the
W=1 level (e.g. -Wformat-security) and eventually by default,
but that are still too noisy at that level.

My own cutoff would be at a few hundred warnings in allmodconfig
builds if there is an effort to reduce it further, but it seems
that this one is still at a few thousand, which does not seem ok.

Arnd