Re: [RFC] spi: expand bits_per_word_mask to 64 bits

From: Mark Brown
Date: Wed Jun 11 2025 - 10:23:27 EST


On Wed, Jun 11, 2025 at 09:16:06AM -0500, David Lechner wrote:
> On 6/10/25 7:05 PM, Da Xue wrote:

> > static int ad7949_spi_probe(struct spi_device *spi)
> > {
> > - u32 spi_ctrl_mask = spi->controller->bits_per_word_mask;
> > + u64 spi_ctrl_mask = spi->controller->bits_per_word_mask;

> I think this driver is incorrectly accessing bits_per_word_mask
> directly and should be using spi_is_bpw_supported() instead.

Yes, that'd be an improvemnet.

Attachment: signature.asc
Description: PGP signature