Re: [PATCH v1 5/5] regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators

[Mark Brown]

On Wed, Jun 11, 2025 at 03:31:37PM +0200, Michael Walle wrote:

> +	} else if (tps->chip_id == TPS652G1) {
> +		nr_buck = ARRAY_SIZE(tps65224_buck_regs);
> +		nr_ldo = ARRAY_SIZE(tps65224_ldo_regs);
>  	} else {

These should all be converted to switch statements rather than if/else
chains for clarity and extensibility.  Otherwise this looks good.

Attachment: signature.asc
Description: PGP signature