Re: [PATCH] ALSA: hda/ca0132: use snprintf() for kernel hardenning

[Takashi Iwai]

On Wed, 11 Jun 2025 15:08:33 +0200,
Dan Carpenter wrote:
> 
> In this sprintf():
> 
> 	sprintf(namestr, "%s %s Volume", name, dirstr[dir]);
> 
> Then "namestr" and "name" buffer are both SNDRV_CTL_ELEM_ID_NAME_MAXLEN
> (44) characters long.  We never actually use that full amount in real
> life so everything works fine, but static checkers complain that if name
> is 44 characters then when you combine that with the other strings it
> will lead to a buffer overflow.  Using snprintf() silences the warning
> and makes the code a little bit safer for the future.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks for the patch, but the very same fix was already submitted from
Lucy and merged in commit a409c60111e6.


Takashi