Re: [PATCH v4 01/10] ASoC: mediatek: common: modify mtk afe platform driver for mt8196

[AngeloGioacchino Del Regno]

Il 10/06/25 11:27, Darren.Ye ha scritto:
> From: Darren Ye <darren.ye@xxxxxxxxxxxx>
>
> Mofify the pcm pointer interface to support 64-bit address access.
>
> Signed-off-by: Darren Ye <darren.ye@xxxxxxxxxxxx>
> ---
>   .../mediatek/common/mtk-afe-platform-driver.c | 47 ++++++++++++-------
>   .../mediatek/common/mtk-afe-platform-driver.h |  2 +
>   2 files changed, 33 insertions(+), 16 deletions(-)
>
> diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.c b/sound/soc/mediatek/common/mtk-afe-platform-driver.c
> index 6b6330583941..a86594dca2b7 100644
> --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.c
> +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.c

..snip..

> diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.h b/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> index fcc923b88f12..9809e60db511 100644
> --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> @@ -12,6 +12,8 @@
>   #define AFE_PCM_NAME "mtk-afe-pcm"
>   extern const struct snd_soc_component_driver mtk_afe_pcm_platform;
>   
> +#define MTK_WORD_SIZE_ALIGN(x) ((x) & (0xfffffffff0))

This doesn't really look like alignment to me, so perhaps change the macro name.
Also, please use the GENMASK macro.

0xfffffffff0 -> GENMASK(39, 4)

after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> +
>   struct mtk_base_afe;
>   struct snd_pcm;
>   struct snd_soc_component;