Re: [PATCH] media: iris: Fix opp scaling of power domains
From: Dikshita Agarwal
Date: Wed Jun 11 2025 - 05:40:12 EST
On 6/11/2025 11:13 AM, Akhil P Oommen wrote:
> Pass PD_FLAG_REQUIRED_OPP flag to allow opp framework to scale the rpmpd
> power domains.
>
> Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxxxx>
Reviewed-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
Thanks,
Dikshita
> ---
> Found this issue while reviewing the Iris source and only compile tested.
> ---
> drivers/media/platform/qcom/iris/iris_probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index 9a7ce142f7007ffcda0bd422c1983f2374bb0d92..4e6e92357968d7419f114cc0ffa9b571bad19e46 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -53,7 +53,7 @@ static int iris_init_power_domains(struct iris_core *core)
> struct dev_pm_domain_attach_data iris_opp_pd_data = {
> .pd_names = core->iris_platform_data->opp_pd_tbl,
> .num_pd_names = core->iris_platform_data->opp_pd_tbl_size,
> - .pd_flags = PD_FLAG_DEV_LINK_ON,
> + .pd_flags = PD_FLAG_DEV_LINK_ON | PD_FLAG_REQUIRED_OPP,
> };
>
> ret = devm_pm_domain_attach_list(core->dev, &iris_pd_data, &core->pmdomain_tbl);
>
> ---
> base-commit: d9946fe286439c2aeaa7953b8c316efe5b83d515
> change-id: 20250527-iris-opp-fix-3ef2591c032a
>
> Best regards,