Re: [PATCH] wifi: zd1211rw: Fix potential data race in zd_mac_tx_to_dev()

[Johannes Berg]

Hi,

So ... I have no idea why you're CC'ing all kinds of people who never
had anything to do with this driver, or haven't worked on WiFi in like a
decade or so ... Please don't. Even I should've been CC'ed with a
different address, at most.

I also have no idea who's maintaining this driver now though, if anyone.
I have hardware if someone wants it ;-)

> In order to avoid potential data races and leading dereference of a NULL
> pointer, acquire the queue lock before any work with the queue is done and
> replace all skb_* calls with their lockless version.

You should explain why the locking changes are OK.

johannes