Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
From: Inochi Amaoto
Date: Wed Jun 11 2025 - 04:30:26 EST
On Wed, Jun 11, 2025 at 10:19:49AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
> > Add bindings for the reset generator on the SOPHGO CV1800B
> > RISC-V SoC.
> >
> > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> > Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > index 1d1b84575960..bd8dfa998939 100644
> > --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > @@ -17,6 +17,7 @@ properties:
> > - sophgo,sg2044-reset
> > - const: sophgo,sg2042-reset
> > - const: sophgo,sg2042-reset
> > + - const: sophgo,cv1800b-reset
>
> Keep alphabetical order. That's enum with previous entry, btw.
>
There is a small question for this: should I move this before the entry
"const: sophgo,sg2042-reset", or before the first item entry?
Regards,
Inochi