Re: [PATCH v4 17/23] ACPI: RISC-V: Create interrupt controller list in sorted order

From: Andy Shevchenko
Date: Wed Jun 11 2025 - 04:21:33 EST


On Tue, Jun 10, 2025 at 10:12:03AM +0530, Sunil V L wrote:
> On Wed, May 28, 2025 at 02:05:36PM +0300, Andy Shevchenko wrote:
> > On Sun, May 25, 2025 at 02:17:04PM +0530, Anup Patel wrote:

...

> > > + __list_add(&ext_intc_element->list, node->list.prev, &node->list);
> >
> > Is this reimplementation of list_add_tail()? And why list debug is excluded here?
> >
> Sure. Let me use list_add_tail() itself in the next revision.

Thanks,

> However, I didn't understand the list debug question. IIUC, list_add_tail()
> is a wrapper around __list_add() and doesn't exclude the list debug, right?

You are right, it's not about debug, it's about using internal function as per
__list_add() documentation:

* This is only for internal list manipulation where we know
* the prev/next entries already!


--
With Best Regards,
Andy Shevchenko