Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

[Krzysztof Kozlowski]

On 11/06/2025 09:15, Nick Hu wrote:
> On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 11/06/2025 05:10, Nick Hu wrote:
>>> SiFive Domain Management controller includes the following components
>>> - SiFive Tile Management Controller
>>> - SiFive Cluster Management Controller
>>> - SiFive Core Complex Management Controller
>>>
>>> These controllers control the clock and power domain of the
>>> corresponding domain.
>>>
>>> However, Since we don't have a SoC specific compatible string yet, so
>>> add '- {}' for the first entry [1][2].
>>
>>
>> But you must have Soc specific compatible strings. See previous discussion.
>>
> Maybe I'm missing something, but since we don't have a SoC-specific compatible
> string yet, I thought we agreed to include a `- {}` as the first
> entry, along with an
> explanation in both the commit message and comments [1].
But your commit msg does not explain. You need to explain why you do not
have SoC specific compatibles. Saying "I do not have a SoC specific
compatible" is not an argument explaining why you do not have SoC
specific compatible.

Best regards,
Krzysztof