Re: [RFC PATCH 1/4] PCI: pcie-rockchip: add bits for Target Link Speed in LCS_2

From: Geraldo Nascimento
Date: Wed Jun 11 2025 - 00:00:05 EST


On Wed, Jun 11, 2025 at 12:46:10AM -0300, Geraldo Nascimento wrote:
> Hi again Bjorn,
>
> Your message reminded me of something that may be important.
>
> During my debugging I had the mild impression L0s capability is not
> being cleared from Link Capabilities Register in the presence of
> "aspm-no-l0s" DT property.
>
> I can't confirm it right now but I might revisit this later on. From
> what I've seen it can only be cleared from inside the port init
> in pcie-rockchip.c and does nothing in present form.
>
> Not a clear, confirmable report but something to watch out for...

Not correct. ASPM bit for L0s is being properly cleared according
to my printk's.

Should have checked before creating noise. Sorry.
Geraldo Nascimento

>
> Regards,
> Geraldo Nascimento