Re: [PATCH] crypto: caam - Set DMA alignment explicitly

From: Herbert Xu
Date: Tue Jun 10 2025 - 22:10:34 EST


On Wed, Jun 04, 2025 at 12:14:46PM +0200, meenakshi.aggarwal@xxxxxxx wrote:
> From: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
>
> Few DMA alignment were missed in the original patch.
>
> Fixes: 4cb4f7c11dee ("crypto: caam - Set DMA alignment explicitly")
>
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> ---
> drivers/crypto/caam/caamalg.c | 22 +++++++++++-----------
> drivers/crypto/caam/caamalg_qi.c | 4 ++--
> 2 files changed, 13 insertions(+), 13 deletions(-)

Why does the request contexts need DMA alignment? There is no DMA memory
in them:

struct caam_skcipher_req_ctx {
struct skcipher_edesc *edesc;
struct skcipher_request fallback_req;
};

struct caam_aead_req_ctx {
struct aead_edesc *edesc;
};

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt