RE: [PATCH] HID: intel-thc: make ptl_ddata static

[Xu, Even]

Hi, Jiri,

Noted, thanks for creating this patch!

I was prepared to submit a fix patch after the current patch set is merged, thank you so much for helping get it done quickly ^_^

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@xxxxxxxxxx>
> Sent: Wednesday, June 11, 2025 3:27 AM
> To: lkp <lkp@xxxxxxxxx>
> Cc: Xu, Even <even.xu@xxxxxxxxx>; bentiss@xxxxxxxxxx; oe-kbuild-
> all@xxxxxxxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; linux-
> input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx;
> Han, Chong <chong.han@xxxxxxxxx>
> Subject: [PATCH] HID: intel-thc: make ptl_ddata static
> 
> From: Jiri Kosina <jkosina@xxxxxxxx>
> 
> ptl_ddata is local to pci-quicki2c.c, so it'd better be static.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505171535.Yrj5T8jh-
> lkp@xxxxxxxxx/
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxxx>
> ---
> 
> This is now in hid.git#for-6.17/intel-thc
> 
>  drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index 208e933e23d8..e944a6ccb776 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -21,7 +21,7 @@
>  #include "quicki2c-hid.h"
>  #include "quicki2c-protocol.h"
> 
> -struct quicki2c_ddata ptl_ddata = {
> +static struct quicki2c_ddata ptl_ddata = {
>  	.max_detect_size = MAX_RX_DETECT_SIZE_PTL,  };
> 
> --
> Jiri Kosina
> SUSE Labs