Re: [PATCH v4 09/14] selftests: harness: Move teardown conditional into test metadata
From: Jason Gunthorpe
Date: Tue Jun 10 2025 - 19:47:10 EST
On Tue, Jun 10, 2025 at 11:48:44AM -0700, Nicolin Chen wrote:
> On Tue, Jun 10, 2025 at 09:09:02AM -0300, Jason Gunthorpe wrote:
> > On Tue, Jun 10, 2025 at 01:38:22PM +0200, Thomas Weißschuh wrote:
> > > > ------------------------------------------------------------------
> > > > # RUN iommufd_dirty_tracking.domain_dirty128M_huge.enforce_dirty ...
> > > > # enforce_dirty: Test terminated unexpectedly by signal 11
> >
> > Sig 11 is weird..
>
> > > On another note, the selftest should use the kselftest_harness' ASSERT_*()
> > > macros instead of plain assert().
> >
> > IIRC the kselftest stuff explodes if you try to use it's assert
> > functions within a fixture setup/teardown context.
> >
> > I also wasn't able to reproduce this (x86 ubuntu 24 LTS OS) Maybe
> > it is ARM specific, I think Nicolin is running on ARM..
>
> Yes. And I was running with 64KB page size. I just quickly retried
> with 4KB page size (matching x86), and all failed tests pass now.
That's a weird thing to be sensitive too. Can you get a backtrace from
the crash, what function/line is crashing?
Jason