Re: [PATCH v3 2/2] iio: adc: adding support for PAC194X

[Andy Shevchenko]

On Tue, Jun 10, 2025 at 03:07:34PM +0000, Marius.Cristea@xxxxxxxxxxxxx wrote:
> On Fri, 2025-06-06 at 12:02 -0500, David Lechner wrote:
> > On 6/6/25 4:39 AM, marius.cristea@xxxxxxxxxxxxx wrote:

...

> > > +#include <linux/acpi.h>
> > > +#include <linux/bitfield.h>
> > > +#include <linux/delay.h>
> > > +#include <linux/err.h>
> > > +#include <linux/i2c.h>
> > > +#include <linux/iio/iio.h>
> > > +#include <linux/iio/events.h>
> > > +#include <linux/iio/sysfs.h>
> > > +#include <linux/unaligned.h>
> > 
> > This seems incomplete. Expecting at least linux/module.h,
> > linux/property.h, etc.
> 
> I will double check. Most probably those module are already included by
> a header.

And this is exactly the problem needs to be addressed.
Read about IFYU principle. That's what we want.

-- 
With Best Regards,
Andy Shevchenko