Re: [PATCH] HID: lenovo: Restrict F7/9/11 mode to compact keyboards only

From: Jiri Kosina
Date: Tue Jun 10 2025 - 15:52:09 EST


On Thu, 5 Jun 2025, Iusico Maxim wrote:

> Commit 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume
> for compact keyboards") introduced a regression for ThinkPad TrackPoint
> Keyboard II by removing the conditional check for enabling F7/9/11 mode
> needed for compact keyboards only. As a result, the non-compact
> keyboards can no longer toggle Fn-lock via Fn+Esc, although it can be
> controlled via sysfs knob that directly sends raw commands.
>
> This patch restores the previous conditional check without any
> additions.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume for compact keyboards")
> Signed-off-by: Iusico Maxim <iusico.maxim@xxxxxxxxx>

CCing Jamie Lentin, the author of the original commit, for awareness.

I've now applied your patch to hid.git#for-6.16/upstream-fixes, thanks.

--
Jiri Kosina
SUSE Labs