Re: [PATCH] ARM: dts: qcom: msm8974-samsung-hlte: Add touchkey support
From: Konrad Dybcio
Date: Tue Jun 10 2025 - 14:58:05 EST
On 6/10/25 6:57 PM, Luca Weiss wrote:
> On 22-04-2025 9:43 p.m., Konrad Dybcio wrote:
>> On 4/19/25 11:08 AM, Luca Weiss wrote:
>>> From: Adam Honse <calcprogrammer1@xxxxxxxxx>
>>>
>>> Add support for the touchkeys on the Samsung Galaxy Note 3 (hlte).
>>>
>>> Signed-off-by: Adam Honse <calcprogrammer1@xxxxxxxxx>
>>> ---
>>> Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
[...]
>>> @@ -332,6 +368,9 @@ pm8941_l24: l24 {
>>> regulator-min-microvolt = <3075000>;
>>> regulator-max-microvolt = <3075000>;
>>> };
>>> +
>>> + pm8941_lvs1: lvs1 {};
>>
>> LVS1 is unused by anything here - it's probably good to define it, so
>> that the driver picks it up and regulator_ignore_unused is aware of it
>
> Yes, did you mean here to put the addition of lvs1 into a separate commit?
I guess I was just thinking out loud, it's okay
Konrad