Re: [GIT PULL] Additional MM updates for 6.16-rc1
From: SeongJae Park
Date: Tue Jun 10 2025 - 13:05:10 EST
Hi Geert,
On Tue, 10 Jun 2025 18:41:43 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Hi Andrew,
>
> On Tue, 10 Jun 2025 at 17:54, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, 10 Jun 2025 11:05:40 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > > On Mon, 2 Jun 2025 at 17:55, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > > - The 2 patch series "mm/damon: build-enable essential DAMON components
> > > > by default" from SeongJae Park reworks DAMON Kconfig to make it easier
> > > > to enable CONFIG_DAMON.
> > >
> > > ... or, make it harder to disable it?
> > >
> > > Given no single defconfig file in v6.15 enables CONFIG_DAMON, I find
> > > it hard to believe defaulting DAMON to "y" is the right thing to do...
> > > (Yes, I have read the rationale in commit 28615e6eed152f2f
> > > ("mm/damon/Kconfig: enable CONFIG_DAMON by default")).
I'm not clearly seeing what is your concern. Could I ask you more
elaborations? I'm not that familiar with distros' config setup process and
defconfigs, so this might be just a silly question, but please bear in mind
with me. I'd like to clearly understand this to avoid making similar problems
later.
> >
> > So what do you recommend? Editing all the defconfigs seems a bit lame.
>
> Just revert the commit?
> Distros are (usually) not using defconfig files anyway.
Reverting the commit is not a big problem for me. But, it would be nice if I
could better understand and agree your concerns, and learn how I could do
better next time.
Thanks,
SJ
[...]