Re: [PATCH] platform/chrome: cros_ec_typec: Defer probe on missing EC parent

[Abhishek Pandit-Subedi]

On Tue, Jun 10, 2025 at 8:39 AM Tomasz Michalec <tmichalec@xxxxxxxxxx> wrote:
>
> If cros_typec_probe is called before EC device is registered,
> cros_typec_probe will fail. It may happen when cros-ec-typec.ko is
> loaded before EC bus layer module (e.g. cros_ec_lpcs.ko,
> cros_ec_spi.ko).
>
> Return -EPROBE_DEFER when cros_typec_probe doesn't get EC device, so
> the probe function can be called again after EC device is registered.
>
> Signed-off-by: Tomasz Michalec <tmichalec@xxxxxxxxxx>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 7678e3d05fd3..f437b594055c 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1272,8 +1272,8 @@ static int cros_typec_probe(struct platform_device *pdev)
>
>         typec->ec = dev_get_drvdata(pdev->dev.parent);
>         if (!typec->ec) {
> -               dev_err(dev, "couldn't find parent EC device\n");
> -               return -ENODEV;
> +               dev_warn(dev, "couldn't find parent EC device\n");
> +               return -EPROBE_DEFER;
>         }
>
>         platform_set_drvdata(pdev, typec);
> --
> 2.50.0.rc0.604.gd4ff7b7c86-goog
>

Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx>