Re: [PATCH] cifs: Show reason why autodisabling serverino support

[Tom Talpey]

The message text is pretty cryptic: "inode numbers won't match anymore".
Can this be stated in a more actionable way? The primary consumer of
the log is the sysadmin, after all.

At a minimum, stating that hardlink detection won't work, as noted in
the commit. Perhaps more helpfully, state that it's not a client issue.

Tom.

On 6/9/2025 3:36 AM, Pali Rohár wrote:
> cifs_autodisable_serverino() is already printing at the VFS level
> information that it is disabling the serverino. It is one time thing as
> once it is disabled, it is not printing it second time. So it does not
> flood logs.
>
> In this change I have just extended this existing logging to print also reason.
>
> On Sunday 08 June 2025 22:40:21 Steve French wrote:
> > Since this could flood logs (e.g. in some DFS cases), probably better
> > to do these via the usual dynamic trace points (and can document a
> > simple "trace-cmd -e smb3_disable_serverino" script to avoid risk of
> > flooding logs.    cifsFYI is an alternative but the world has moved to
> > the dynamic tracing (eBPF etc.)
> >
> > On Sun, Jun 8, 2025 at 3:57 PM Paulo Alcantara <pc@xxxxxxxxxxxxx> wrote:
> > > Pali Rohár <pali@xxxxxxxxxx> writes:
> > >
> > > > Before calling cifs_autodisable_serverino() function, show reason why it
> > > > has to be called.
> > > >
> > > > This change allows to debug issues why cifs.ko decide to turn off server
> > > > inode number support and hence disable support for detection of hardlinks.
> > > >
> > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > > > Cc: stable@xxxxxxxxxxxxxxx
> > > > ---
> > > >   fs/smb/client/connect.c   | 2 ++
> > > >   fs/smb/client/dfs_cache.c | 2 ++
> > > >   fs/smb/client/inode.c     | 3 +++
> > > >   fs/smb/client/readdir.c   | 3 +++
> > > >   4 files changed, 10 insertions(+)
> > >
> > > NACK.
> >
> >
> > --
> > Thanks,
> >
> > Steve