Re: [PATCH] coccinelle: misc: secs_to_jiffies script: Create dummy report

[Ricardo Ribalda]

Hi

On Wed, 29 Jan 2025 at 18:38, Easwar Hariharan
<eahariha@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 1/29/2025 12:06 AM, Ricardo Ribalda wrote:
> > When running cocci in report mode, eg:
> > $make coccicheck M="$dir" MODE=report
> >
> > It returns this error:
> > virtual rule report not supported
> > coccicheck failed
> > make: *** [Makefile:251: __sub-make] Error 2
> >
> > Create a dummy rule to avoid this error and run the other cocci scripts.
> >
> > Fixes: 551dbd1ec7ff ("coccinelle: misc: add secs_to_jiffies script")
> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> > ---
> >  scripts/coccinelle/misc/secs_to_jiffies.cocci | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> > index 8bbb2884ea5d..2d85dca16418 100644
> > --- a/scripts/coccinelle/misc/secs_to_jiffies.cocci
> > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> > @@ -10,6 +10,7 @@
> >  //
> >
> >  virtual patch
> > +virtual report
> >
> >  @depends on patch@ constant C; @@
> >
> > @@ -20,3 +21,8 @@ virtual patch
> >
> >  - msecs_to_jiffies(C * MSEC_PER_SEC)
> >  + secs_to_jiffies(C)
> > +
> > +// Dummy rule for report mode that would otherwise be empty and make spatch
> > +// fail ("No rules apply.")
> > +@script:python depends on report@
> > +@@
> >
>
> Sorry about that, and thanks for the patch!
>
> FWIW,
>
> Reviewed-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>

I just checked on 6.16rc1 and it is still failing.

Could we land this while Mark's series is under review?

Thanks!


-- 
Ricardo Ribalda