Re: [PATCH V3 0/3] Adjust some error messages for SD UHS-II initialization process

From: Ulf Hansson
Date: Tue Jun 10 2025 - 09:09:52 EST


On Fri, 6 Jun 2025 at 13:01, Victor Shih <victorshihgli@xxxxxxxxx> wrote:
>
> From: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
>
> Summary
> =======
> It is normal that errors will occur when using non-UHS-II card to enter
> the UHS-II card initialization process. We should not be producing error
> messages and register dumps. Therefore, switch the error messages to debug
> mode and register dumps to dynamic debug mode.
>
> Patch structure
> ===============
> patch#1: for core
> patch#2-#3: for sdhci
>
> Changes in v3 (June. 06, 2025)
> * Rebase on latest mmc/next.
> * Patch#2: Separate the helper function in V2 patch#2 into V3 patch#2.
>
> ----------------- original cover letter from v2 -----------------
> Summary
> =======
> It is normal that errors will occur when using non-UHS-II card to enter
> the UHS-II card initialization process. We should not be producing error
> messages and register dumps. Therefore, switch the error messages to debug
> mode and register dumps to dynamic debug mode.
>
> Patch structure
> ===============
> patch#1: for core
> patch#2: for sdhci
>
> Changes in v2 (May. 23, 2025)
> * Rebase on latest mmc/next.
> * Patch#1: Drop the use of DBG macro and use pr_debug() instead.
> * Patch#2: Drop the use of DBG macro in some function
> and use pr_debug() instead.
>
> ----------------- original cover letter from v1 -----------------
> Summary
> =======
> It is normal that errors will occur when using non-UHS-II card to enter
> the UHS-II card initialization process. We should not be producing error
> messages and register dumps. Therefore, switch the error messages to debug
> mode and register dumps to dynamic debug mode.
>
> Patch structure
> ===============
> patch#1: for core
> patch#2: for sdhci
>
> Changes in v1 (May. 16, 2025)
> * Rebase on latest mmc/next.
> * Patch#1: Adjust some error messages for SD UHS-II cards.
> * Patch#2: Adjust some error messages and register dump for SD UHS-II card
>
> Victor Shih (3):
> mmc: core: Adjust some error messages for SD UHS-II cards
> mmc: sdhci: Add a helper function for dump register in dynamic debug
> mode
> mmc: sdhci-uhs2: Adjust some error messages and register dump for SD
> UHS-II card
>
> drivers/mmc/core/sd_uhs2.c | 4 ++--
> drivers/mmc/host/sdhci-uhs2.c | 20 ++++++++++----------
> drivers/mmc/host/sdhci.h | 16 ++++++++++++++++
> 3 files changed, 28 insertions(+), 12 deletions(-)
>
> --
> 2.43.0
>

The series applied for next, thanks!

Kind regards
Uffe