Re: linux-next: build failure after merge of the rust-pin-init tree
From: Miguel Ojeda
Date: Tue Jun 10 2025 - 05:56:59 EST
On Tue, Jun 10, 2025 at 10:15 AM Benno Lossin <lossin@xxxxxxxxxx> wrote:
>
> @Miguel, @Andreas, how should I go about this? Send the commit above
> augmented with the diff, or send a patch with just the diff to the list?
> Or apply the diff directly to the commit in the pin-init-next branch &
> rebasing (potentially adding an Acked-by from Andreas)? Or some other
> way?
If I understand correctly, the commit that introduced the issue
(0bcaea04244b) is in your branch (rust/pin-init-next), thus you should
fix it in your branch.
Personally, I would just rebase, since you just applied them hours ago.
As a maintainer, you are trusted to not introduce a change that others
could disagree with (especially on their files) -- but you already
told Andreas and discussed it here, so you did the right thing :)
You can consider mentioning the change in the [ ... ] part, if you want.
Thanks!
Cheers,
Miguel